bump project deps, inline-snapshot config, add templates #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR bumps various project dependencies, adds inline-snapshot tool configuration, and introduces an HTML template with a corresponding FastAPI endpoint.
- Updated dependency versions in
pyproject.tomland adjusted Makefile snapshot flags. - Added
templates/index.htmland a new/indexroute using Jinja2Templates. - Updated
compose.ymlandDockerfileto mount and copy the templates directory andpyproject.toml.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/index.html | Added a Tabler-based HTML template for the app |
| pyproject.toml | Bumped versions and configured tool.inline-snapshot |
| compose.yml | Mounted app, tests, and templates directories for development |
| app/main.py | Integrated Jinja2Templates, added /index endpoint, commented scheduler setup |
| Makefile | Changed inline-snapshot invocation from create to fix |
| Dockerfile | Copied templates/ and pyproject.toml into the image |
Comments suppressed due to low confidence (2)
app/main.py:71
- Consider adding a test for this new
/indexroute to verify the HTMLResponse and template rendering work as expected.
@app.get("/index", response_class=HTMLResponse)
app/main.py:76
- [nitpick] These commented-out scheduler lines could benefit from a short TODO or comment explaining when and why they'll be re-enabled to aid future maintainers.
# _scheduler_data_store = SQLAlchemyDataStore(engine, schema="scheduler")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.